Implement DAO Factory pattern#3282
Merged
iluwatar merged 10 commits intoiluwatar:masterfrom Feb 8, 2026
Merged
Conversation
PR SummaryThis PR implements the DAO Factory pattern, providing flexible data access by switching between H2, Mongo, and JSON flat file data sources. It includes a Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (8)
Files Processed (24)
- dao-factory/README.md (1 hunk)
- dao-factory/etc/dao-factory.png (0 hunks)
- dao-factory/etc/dao-factory.puml (1 hunk)
- dao-factory/pom.xml (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/App.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/CustomException.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/Customer.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/CustomerDAO.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/DAOFactory.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/DAOFactoryProvider.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/DataSourceType.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/FlatFileCustomerDAO.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/FlatFileDataSourceFactory.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/H2CustomerDAO.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/H2DataSourceFactory.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/MongoCustomerDAO.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/MongoDataSourceFactory.java (1 hunk)
- dao-factory/src/main/resources/logback.xml (1 hunk)
- dao-factory/src/test/java/com/iluwatar/daofactory/AppTest.java (1 hunk)
- dao-factory/src/test/java/com/iluwatar/daofactory/DAOFactoryTest.java (1 hunk)
- dao-factory/src/test/java/com/iluwatar/daofactory/FlatFileCustomerDAOTest.java (1 hunk)
- dao-factory/src/test/java/com/iluwatar/daofactory/H2CustomerDAOTest.java (1 hunk)
- dao-factory/src/test/java/com/iluwatar/daofactory/MongoCustomerDAOTest.java (1 hunk)
- pom.xml (2 hunks)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 9afad6d: add pom.xml
Files Processed (24)
- dao-factory/README.md (1 hunk)
- dao-factory/etc/dao-factory.png (0 hunks)
- dao-factory/etc/dao-factory.puml (1 hunk)
- dao-factory/pom.xml (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/App.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/CustomException.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/Customer.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/CustomerDAO.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/DAOFactory.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/DAOFactoryProvider.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/DataSourceType.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/FlatFileCustomerDAO.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/FlatFileDataSourceFactory.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/H2CustomerDAO.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/H2DataSourceFactory.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/MongoCustomerDAO.java (1 hunk)
- dao-factory/src/main/java/com/iluwatar/daofactory/MongoDataSourceFactory.java (1 hunk)
- dao-factory/src/main/resources/logback.xml (1 hunk)
- dao-factory/src/test/java/com/iluwatar/daofactory/AppTest.java (1 hunk)
- dao-factory/src/test/java/com/iluwatar/daofactory/DAOFactoryTest.java (1 hunk)
- dao-factory/src/test/java/com/iluwatar/daofactory/FlatFileCustomerDAOTest.java (1 hunk)
- dao-factory/src/test/java/com/iluwatar/daofactory/H2CustomerDAOTest.java (1 hunk)
- dao-factory/src/test/java/com/iluwatar/daofactory/MongoCustomerDAOTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
| return switch (dataSourceType) { | ||
| case H2 -> new H2DataSourceFactory(); | ||
| case MONGO -> new MongoDataSourceFactory(); | ||
| case FLAT_FILE -> new FlatFileDataSourceFactory(); |
Contributor
There was a problem hiding this comment.
As per the provided documentation -
default -> throw new IllegalArgumentException("Unsupported data source type");
Contributor
Author
There was a problem hiding this comment.
As per the provided documentation -
default -> throw new IllegalArgumentException("Unsupported data source type");
Thanks, I fixed it
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 2a66d97: fix: throw exception + refactor
Files Processed (2)
- dao-factory/src/main/java/com/iluwatar/daofactory/DAOFactoryProvider.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
|
|
This PR is stale because it has been open 60 days with no activity. |
Owner
|
@all-contributors please add @letdtcode for code |
Contributor
|
I've put up a pull request to add @letdtcode! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
What does this PR do?
This pull request implements the DAO Factory pattern, which demonstrates how the application should be switch between three different types of data sources (H2, Mongo, Json flat file). It includes code documented implementation, comprehensive tests, detailed documentation.
Key features
Related Issue
Closes #1270