This repository was archived by the owner on Dec 14, 2023. It is now read-only.
Increase readability#741
Open
rotelok wants to merge 18 commits intoicecoder:masterfrom
rotelok:increase-readability
Open
Increase readability#741rotelok wants to merge 18 commits intoicecoder:masterfrom rotelok:increase-readability
rotelok wants to merge 18 commits intoicecoder:masterfrom
rotelok:increase-readability
Conversation
it's equivalent and easier to read this constant was introduced in php version 5.3.
and (float)$var, it's faster and more future proof
it's faster and more readable
for ($i=0;$i<count($var);$i++) to for ($i=0, $iMax = count($var); $i< $iMax; $i++) so we don't spend processor time counting the same variable every loop iteration
the commit had unintende consequences ( broke the file manager, probably more stuff )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spread a few refactors in small commits so you could cherry-pick the ones you like
most commits are just of one of three categories.
It seems like a lot of changes, but it's not, it's just small corrections on many files, functionality wise everything should be the same, I made an effort to use equivalent constructs every time I made a change, so input/output of the functions shouldn't change
( reverting commit 6ed2edb to fix errors )