[CI] Added code samples testing with Deptrac #2562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnocon
force-pushed
the
add-deptrac
branch
2 times, most recently
from
a226602 to
da0eced
Compare
mnocon
changed the title
Preview of modified filesPreview of modified Markdown: |
konradoboza
approved these changes
Oct 1, 2025
Contributor
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
Great work! 💪
Just a few nitpicks:
code_samples/back_office/limitation/src/Controller/CustomController.php
Outdated
Show resolved
Hide resolved
...amples/back_office/limitation/src/Security/Limitation/Mapper/CustomLimitationValueMapper.php
Outdated
Show resolved
Hide resolved
...ack_office/limitation/templates/themes/standard/limitation/custom_limitation_value.html.twig
Outdated
Show resolved
Hide resolved
mnocon
changed the title
mnocon
force-pushed
the
add-deptrac
branch
3 times, most recently
from
d915fd4 to
4146d4e
Compare
adriendupuis
approved these changes
Feb 10, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target: 5.0 only, for new code only.
Deptrac is a code testing tool for architecture.
I've added a very simple ruleset - code samples should not use classes outside of the
Ibexa\Contractsnamespace.Together with @konradoboza we've also added a few additional exceptions - like SiteAccess configuration classes etc.
This tool should act as a:
Contracts-compliantway of writing the code sample)But we will never get rid of all the errors, as they would require architecture changes on the DXP side - so we will have to keep expanding the baseline with new code samples.
Generated baseline:
https://github.com/ibexa/documentation-developer/blob/add-deptrac/deptrac.baseline.yaml