[Behat] IBX-11133 Added enabled option for Help center#1808
Open
pawlakadrian wants to merge 2 commits into4.6from
Open
[Behat] IBX-11133 Added enabled option for Help center#1808pawlakadrian wants to merge 2 commits into4.6from
pawlakadrian wants to merge 2 commits into4.6from
Conversation
pawlakadrian
force-pushed
the
IBX-11133-help-center-user-settings
branch
from
348087e to
02ba14f
Compare
pawlakadrian
force-pushed
the
IBX-11133-help-center-user-settings
branch
from
2ace325 to
2c6f5bc
Compare
|
ibexa-workflow-automation-1
bot
requested review from
KamilSznajdrowicz,
barbaragr,
juskora,
katarzynazawada,
micszo and
tomaszszopinski
and removed request for
a team
Contributor
tomaszszopinski
left a comment
tomaszszopinski
left a comment
There was a problem hiding this comment.
Just some nitpicks :)
| public function enableHelpCenter(): void | ||
| { | ||
| $this->contentActionsMenu->verifyIsLoaded(); | ||
| $this->getHTMLPage()->find($this->getLocator('helpCenterValueDropdown'))->click(); |
Contributor
There was a problem hiding this comment.
I would add timeout here - just to be sure.
| } | ||
|
|
||
| /** | ||
| * @Given I enable Help center |
Contributor
There was a problem hiding this comment.
I would go with either 'help center' or 'Help Center'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Added additional options (enable/disable) for help center
For QA:
Documentation: