IBX-10756: Notification page ignores user language preferences#1788
Merged
IBX-10756: Notification page ignores user language preferences#1788
Conversation
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
|
Steveb-p
approved these changes
Feb 5, 2026
barw4
approved these changes
Feb 6, 2026
konradoboza
approved these changes
Feb 9, 2026
juskora
force-pushed
the
IBX-10756-all-notifications-locale-fix
branch
from
b7f8fb5 to
2354a43
Compare
|
Contributor
|
QA Approved on Ibexa DXP Commerce 4.6-dev. |
juskora
approved these changes
Feb 10, 2026
ViniTou
requested changes
Feb 10, 2026
Contributor
ViniTou
left a comment
ViniTou
left a comment
There was a problem hiding this comment.
I am almost sure that controller was there for a reason. Are we sure that both notifications views were checked?
Contributor
|
We probably need an input from @tbialcz once he's back, there is a potential case we didn't check on review. |
mikadamczyk
approved these changes
Feb 11, 2026
tbialcz
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
All notifications page was always falling back to first backoffice langauge
That was because
AllNotificationsControllerwas redirecting toNotificationsControllerthrough forward, that meant the request was being treated as a sub request andRequestLocaleListenerwould skip setting the locale on it (it only does it for master requests)I have removed the controller since this forward was the only thing in that controller and moved the redirect to yaml configuration.