Skip to content

Conversation

@pulpdrew
Copy link
Contributor

Closes HDX-3033

Summary

This PR fixes three bugs in the Services Dashboard

  1. When using CTEs in chart configs, as we do on the HTTP and Databases tabs, there were frequent console errors as we tried to DESCRIBE the CTE names, to support the materialized columns optimization. With this PR, we no longer try to DESCRIBE CTEs, by skipping the materialized column optimization for configs without a from.databaseName.
  2. Previously, the Request Throughput chart would reload whenever switching the Request Error Rate chart from Overall to By Endpoint. This was because the displayType in the Request Throughput chart was based on the toggle state, despite being unrelated. Now, the displayType of the Request Throughput chart is constant, eliminating the extra refetch.
  3. Previously, when switching to the Services dashboard with a non-Trace Source ID in the URL params, the Services dashboard would initially be empty, then after toggling to a Trace Source, queries would briefly be issued against the non-Trace source (they would fail and/or be cancelled a moment later). Now, non-Trace sources are filtered out so that a Trace source is chosen as the default, and non-Trace sources are not queried.

@vercel
Copy link

vercel bot commented Dec 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Dec 15, 2025 8:23pm

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

🦋 Changeset detected

Latest commit: 473a485

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/common-utils Patch
@hyperdx/api Patch
@hyperdx/app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link

claude bot commented Dec 15, 2025

Code Review

  • CRITICAL: Test file has describe.only at packages/api/src/clickhouse/__tests__/renderChartConfig.test.ts:39 → Remove .only to run all tests
  • ⚠️ Potential infinite loop: useEffect at ServicesDashboardPage.tsx:1378 syncs appliedConfig.sourceappliedConfigParams.source, but appliedConfig is derived from appliedConfigParams via useMemo → Verify no render loop occurs when trace sources change
  • ⚠️ useForm changed from values to defaultValues at ServicesDashboardPage.tsx:1363 → This means form won't update when appliedConfig changes. If URL params change, form will be stale. Consider if this is intentional or needs reset() on param changes.

Otherwise looks good - fixes for CTE DESCRIBE errors and displayType refetch issue are sound.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

E2E Test Results

All tests passed • 45 passed • 3 skipped • 320s

Status Count
✅ Passed 45
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 3

View full report →

@pulpdrew pulpdrew force-pushed the drew/services-dashboard-fixes branch from f3f07bb to 473a485 Compare December 15, 2025 20:20
@pulpdrew pulpdrew requested review from a team and knudtty and removed request for a team December 15, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants