-
Notifications
You must be signed in to change notification settings - Fork 339
fix: Fix Services Dashboard bugs #1484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 473a485 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Code Review
Otherwise looks good - fixes for CTE DESCRIBE errors and displayType refetch issue are sound. |
E2E Test Results✅ All tests passed • 45 passed • 3 skipped • 320s
|
bfe0947 to
11364af
Compare
03f45c6 to
50a89f8
Compare
1190a2a to
f3f07bb
Compare
f3f07bb to
473a485
Compare
Closes HDX-3033
Summary
This PR fixes three bugs in the Services Dashboard
DESCRIBEthe CTE names, to support the materialized columns optimization. With this PR, we no longer try to DESCRIBE CTEs, by skipping the materialized column optimization for configs without afrom.databaseName.OveralltoBy Endpoint. This was because thedisplayTypein the Request Throughput chart was based on the toggle state, despite being unrelated. Now, the displayType of the Request Throughput chart is constant, eliminating the extra refetch.