This repository was archived by the owner on Jul 4, 2022. It is now read-only.
ERC721: path towards completion V2#25
Open
exp-table wants to merge 3 commits intohuff-language:masterfrom
Open
ERC721: path towards completion V2#25exp-table wants to merge 3 commits intohuff-language:masterfrom
exp-table wants to merge 3 commits intohuff-language:masterfrom
Conversation
Closed
Contributor
|
What is the reason for the changes to package-lock.json? |
Collaborator
Author
None, it was an error! I rolled it back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the ERC721 implementation more compliant with the standard.
1. Interface fix
Some of the view functions were marked as
nonpayableinstead ofview.2. Support for constructor arguments
Support for both name and symbol have been added.
You can find the function to properly encode the arguments in
scripts/deploy.js.For it to work, it's required that both the name and symbol are short strings (at most 31 bytes).
The corresponding view functions return the appropriate data.