Can modify options after initialization and invoking countdown method#258
Open
jjwann wants to merge 3 commits intohilios:masterfrom
Open
Can modify options after initialization and invoking countdown method#258jjwann wants to merge 3 commits intohilios:masterfrom
jjwann wants to merge 3 commits intohilios:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I don't know if I'm using GitHub properly, but I made the following change to the codebase. When initializing the countdown timer, I could pass in an object with a defer property such that I could start the timer at a later time. However, when I invoke the "countdown" method later the timer starts immediately. I wanted the option such that I could specify that future invocations of the "countdown" method requires an explicit call to "start" to actually start the timer.
Having made the modification, I might as well provide the user the ability to specify other options when invoking the "countdown" method (specifically, he/she can set the elapse and precision option for the next invocation).