Swap out renderToStaticMarkup from react-dom/server for client-friendly renderer#545
Open
bensaufley wants to merge 2 commits intohighcharts:masterfrom
Open
Swap out renderToStaticMarkup from react-dom/server for client-friendly renderer#545bensaufley wants to merge 2 commits intohighcharts:masterfrom
bensaufley wants to merge 2 commits intohighcharts:masterfrom
Conversation
…ly renderer\ \ Resolves highcharts#544. I'm not clear on how TS plays into this - files are mostly .js with .d.ts files, but the build command is npx tsc, so it should accept TypeScript files fine. With that in mind, I used TS.
react-dom was already in use by the code now being replaced; this just makes sure types are taken care of
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #544.
I'm not clear on how TS plays into this - files are mostly .js with .d.ts files, but the build command is npx tsc, so it should accept TypeScript files fine. With that in mind, I used TS.