Skip to content

Supply tree mock api#92

Open
NimeshaKahingala wants to merge 5 commits intomainfrom
supply-tree-mock-api
Open

Supply tree mock api#92
NimeshaKahingala wants to merge 5 commits intomainfrom
supply-tree-mock-api

Conversation

@NimeshaKahingala
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@RobertLRead RobertLRead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @NimeshaKahingala and @JamesPagetButler,

I'm approving this request, but there are some things I don't understand about it. It appears to hard-code the cookie recipe, in a way that doesn't seem right. I'm sure it is an improvement---you can merge it you want---but I would like to understand this. Possibly it is reasonable to do, but if it is really hard-wiring a value like that, we need to document and understand. You can answer in Discord, if I have misunderstood, because I might have.

@RobertLRead
Copy link
Collaborator

And, actually, you appear to be changing the port number, and I need to understand that--why is the port number changing?

@Jbutler-helpful
Copy link
Collaborator

@NimeshaKahingala have you done an update since our last conversation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants