add an optional category to be inserted into the path#35
Open
rngadam wants to merge 1 commit intoheapsource:masterfrom
Open
add an optional category to be inserted into the path#35rngadam wants to merge 1 commit intoheapsource:masterfrom
rngadam wants to merge 1 commit intoheapsource:masterfrom
Conversation
Contributor
|
Sorry for the late reply. The change looks clean. Your example, however, does not show the usage of 'category'. I'm still not sure how it adds any value in addition to what is achieved by the keys like 'thumb', 'original', 'detail' etc. Is this really a commonly required use case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us group attachments (for a particular customer or event).
Given this configuration:
output of image property is: