Define a common StrictTriple for internal use #1170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
meooow25
commented
Dec 28, 2025
meooow25
commented
- Move StrictPair to Utils.Containers.Internal.Strict next to StrictTriple
- Remove the currently unused strict Maybe
* Remove the currently unused strict Maybe * Move StrictPair to Utils.Containers.Internal.Strict next to StrictTriple
treeowl
reviewed
Dec 28, 2025
|
|
||
|
|
||
| data SplitLookup a = SplitLookup !(IntMap a) !(Maybe a) !(IntMap a) | ||
| type SplitLookup a = StrictTriple (IntMap a) (Maybe a) (IntMap a) |
Contributor
There was a problem hiding this comment.
Have you tried stitching to an unlifted maybe here? I don't remember if I have.
Contributor
Author
There was a problem hiding this comment.
Would that make a difference compared to simply being strict?
But switching to an unboxed/unpacked Maybe would avoid allocating the Justs, we could try that later.
Contributor
There was a problem hiding this comment.
It's just one allocation, so probably not a big deal, but yeah, I think it'd be worth trying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.