Provide a behaviour for identity providers storage#56
Open
adanselm wants to merge 1 commit intohandnot2:masterfrom
Open
Provide a behaviour for identity providers storage#56adanselm wants to merge 1 commit intohandnot2:masterfrom
adanselm wants to merge 1 commit intohandnot2:masterfrom
Conversation
…ementation that does exactly the same as before (read from configuration)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to de-correlate identity providers storage from the rest of the application.
A
Samly.IdpDataStore.Storebehaviour was created, as well as a default implementationSamly.IdpDataStore.Configthat does exactly the same as before (read from configuration).A new configuration option was added to customize the IdP storage module to be used:
If not provided, the default one will be used.
This is intended as a first step towards dynamic IdP data storage. Next step will be to try another implementation and check if Samly's public interface provides all functions needed.