doPeriodicRequests -> doorStatusSupported. button entity #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bcs im a filthy windows user
…oth building targets run on windows and linux (i think)
…d, publish a button instead of a cover / garage entity to HA, because the open stop close logic can't be applied without door status. include the "PRESS" command handling for the button entity case.
halacs
reviewed
Jan 1, 2026
cli/homeAssistant/client.go
Outdated
| } | ||
|
|
||
| mqttToken := ha.mqttClient.Publish(ha.getDiscoveryTopic(), qosAtLeastOnce, true, discoveryMsg) | ||
| mqttToken := ha.mqttClient.Publish(ha.getDiscoveryTopic(!ha.doorStatusSupported), qosAtLeastOnce, true, discoveryMsg) |
Owner
There was a problem hiding this comment.
I propose to remove the parameter of getDiscoveryTopic() since that information is already available for that function internally. How do you see?
Contributor
Author
There was a problem hiding this comment.
You are right it is redundant. I will remove it :D
In the meantime, I also wrote a very basic form of multi door support where you provide all the devicePorts as a list in the config. I will commit this as well because I don't know how to commit the fix to the PR without all the other changes ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename doPeriodicRequest flag to doorStatusSupported. if not supported, publish a button instead of a cover / garage entity to HA, because the open stop close logic can't be applied without door status. include the "PRESS" command handling for the button entity case.