Skip to content

Conversation

@nalka0
Copy link
Contributor

@nalka0 nalka0 commented Dec 25, 2023

This PR contains all the changes I made to make unity spy work on a game using Unity 2022.3.10.

I'm unsure how to create a complete new offset object and would need help with it (I commented the offsets I had to replace with the values I figured out).

There are also some non-offset changes, these probably need some work/testing to make them compatible with all other supported unity versions.

@nalka0 nalka0 marked this pull request as draft December 25, 2023 21:38
@sebastientromp
Copy link
Collaborator

sebastientromp commented Jan 14, 2024

So the first step to define a new version is to add a new public static readonly MonoLibraryOffsets declaration in MonoLibraryOffsets.cs. By convention, the variable name has the version name, as well as whether it's for a 32- or 64-bits game.
Then you need to fill out all the new offsets. Some of them might have stayed the same, but you'll still have to provide a value for all of them.

Once this is done, you can add it to the List<MonoLibraryOffsets> SupportedVersions in MonoLibraryOffsets.cs.

Normally, these are the only places you should need to modify. If there are other pieces of the code that don't work with that new version, we'll need to investigate more thoroughly.
Edit: Also add the new version to the UnityVersions class like you did

int classCache = this.Process.MonoLibraryOffsets.ImageClassCache;
var classCacheSize = this.ReadUInt32(classCache + this.Process.MonoLibraryOffsets.HashTableSize);
var classCacheTableArray = this.ReadPtr(classCache + this.Process.MonoLibraryOffsets.HashTableTable);
var classCacheSize = this.ReadUInt32(/*classCache + this.Process.MonoLibraryOffsets.HashTableSize*/1256);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I only know the good values for classeCache + HashTableSize and classCache + HashTableTable but I have no idea about the individual values of each offset

// Get the generic type arguments
if (this.TypeInfo.TypeCode == TypeCode.GENERICINST)
{
this.fieldCount = this.ReadInt32(96);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I can't simply use 96 for the TypeDefinitionFieldCount offset since this line isn't always executed at the same time as the line that uses TypeDefinitionFieldCount


var fields = new List<FieldDefinition>();
if (this.ClassKind == MonoClassKind.GInst)
if (this.ClassKind is MonoClassKind.GInst or MonoClassKind.GParam)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't simply an offset change

private TypeDefinition GetGeneric()
{
if (this.ClassKind != MonoClassKind.GInst)
if (this.ClassKind is MonoClassKind.GInst or MonoClassKind.GParam)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't simply an offset change

case TypeCode.U4:
return sizeof(uint);

return 8;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be bound to offsets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants