Fix incoming url parsing in HttpServer.Request #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's slight differences in how node and gren parse URLs. This moves the parsing logic into Gren where it should be. Fixes #29
blaix
added a commit
to gren-lang/integration-tests
that referenced
this pull request
May 10, 2025
This fails on 5.0.3 but will pass when gren-lang/node#30 is released.
This was referenced May 10, 2025
blaix
added a commit
to gren-lang/integration-tests
that referenced
this pull request
May 12, 2025
This is a test for the fix in gren-lang/node#30 released in 5.0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's slight differences in how node and gren parse URLs. This moves the parsing logic into Gren where it should be.
Fixes #29