Open
Conversation
fixes value error on line 386 using registers.index, first index will always be zero, which causes error, try except now catches that, and script works for format strings
fuzzywalls
reviewed
Sep 12, 2024
| try: | ||
| register_index = registers.index(register_used[0].toString()) | ||
| except ValueError: | ||
| print("List does not contain value") |
Collaborator
There was a problem hiding this comment.
@sparrow-labz Thanks for submitting the pull request. I don't think I've ever run across this error so I'm wondering if it's an architecture problem? (arm vs x86 vs etc) Could you give a little background on how you ran across this and maybe provide the binary? Regardless, this looks like it should still throw an exception since the ValueError exception would result in register_index not being declared but is used in the FormatFunction instantiation a few lines below.
Author
There was a problem hiding this comment.
I ran leafblower on an arm bootloader binary for an older Samsung phone, from the A series. I'll try to find the binary, and add it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes value error on line 386 using registers.index,
First index will always be zero, which causes error, try except now catches that, and script works for format strings