Open
Conversation
Contributor
|
These changes seem reasonable to me. I'm good with both of them. Build is failing during testing of server assembly. I think we discussed elsewhere that test expectations need updated following the changes to the version command. |
ongdb does not need special memory information when running version
d797077 to
eae1430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ongdb.confand when that happens running the unixongdbrelease script with that file results in a very unhappy system. Tolerating those line endings seems reasonable, as users generally expect conf files to be portable and not to need to worry about line endings.ongdb versionwithout java preallocated gb's of memory forongdb-- we have containers that run with enough space for one copy ofongdbbut definitely not enough space for two copies ofongdb, but it should be possible to runongdb versionas that doesn't require the preallocation defined inongdb.conf-- Simplify the start script to do minimal work when getting version (skippingsetup_java_opts, most ofsetup_arbiter_options).