Remove duplicate enterprise startup logic

[SpecialThing44]

• As far as I can tell, this is a duplicate of the logic in org.neo4j.server.enterprise.EnterpriseNeoServer#start. which calls createDbFactory function.

[bradnussbaum]

I'm not following the logic on why this is duplicate startup logic. How do OpenEnterpriseCoreGraphDatabase and OpenEnterpriseReadReplicaGraphDatabase get initialized based on the CORE/READ_REPLICA mode?

[SpecialThing44]

See the implementation of createDbFactory in OpenEnterpriseNeoServer, which is already the default call on the switch statement in EnterpriseNeoServer.
That implementation covers all of the cases that the code I am removing covers, unless I am missing something.

[bradnussbaum]

This will need to be investigated further as EnterpriseNeoServer.createDbFactory handles the mode for CORE and READ_REPLICA differently than OpenEnterpriseNeoServer.createDbFactory by initializing OpenEnterpriseCoreGraphDatabase and OpenEnterpriseReadReplicaGraphDatabase which extend CoreGraphDatabase and ReadReplicaGraphDatabase but have different construction. So it's not exactly the same. Now it might be possible to simplify but I don't think we can just change it without further considerations.

[SpecialThing44]

I see it now :)