Python SDK: Fix MacOS Wifi and Bump Deps #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcamise-gpsw
force-pushed
the
bump_python_sdk_deps
branch
2 times, most recently
from
0ab8367 to
221d8b3
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates third-party dependencies and adds compatibility for macOS 15+ privacy features that redact WiFi SSID names. The key changes include:
- Updated multiple third-party dependencies to newer versions (bleak, certifi, pydantic, pyobjc-core, etc.)
- Modified WiFi connection logic to handle SSID redaction on macOS 15+ by relying on connection state instead of SSID name verification
- Removed unnecessary
type: ignorecomments that are no longer needed with updated type checking
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| thirdPartyDependencies.csv | Updated versions for 25+ third-party dependencies |
| pyproject.toml | Updated dependency version constraints for bleak, wrapt, protobuf, and Pillow; added ignore-paths for pylint |
| open_gopro/network/wifi/controller.py | Added documentation about SSID redaction on macOS 15+ |
| open_gopro/network/wifi/client.py | Modified connection check to rely on state instead of SSID name |
| open_gopro/network/wifi/adapters/wireless.py | Added macOS 15+ compatibility by skipping SSID scanning and verification when redacted |
| open_gopro/network/ble/services.py | Removed obsolete type: ignore comments |
| open_gopro/network/ble/adapters/bleak_wrapper.py | Updated type hints to use proper types from bleak library |
| open_gopro/models/network_scan_responses.py | Added pylint disable comments for unused parameters |
| open_gopro/gopro_wireless.py | Added necessary type: ignore comments for override methods |
| open_gopro/gopro_base.py | Removed unnecessary docstring section and added type: ignore comments |
| open_gopro/features/streaming/stream_feature.py | Added type: ignore comment with explanation for arg-type issue |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
demos/python/sdk_wireless_camera_control/open_gopro/network/wifi/adapters/wireless.py
Outdated
Show resolved
Hide resolved
demos/python/sdk_wireless_camera_control/open_gopro/network/wifi/adapters/wireless.py
Show resolved
Hide resolved
tcamise-gpsw
changed the title
- Skip WiFi pre-scan on macOS 15+ where system_profiler redacts SSID names - Skip current() check before connecting on macOS 15+ to prevent hangs during network transitions - Use connection state verification instead of SSID string matching on macOS 15+ - Fix current() method to only fallback to system_profiler if ipconfig fails - Replace bare except with except Exception for better error handling - Modified NetworksetupWireless.current() to return (None, CONNECTED) when SSID is redacted but connection is active - Updated WifiClient.is_connected to check state only, not SSID - Removed RuntimeError on redacted SSID detection - Added documentation about macOS 15+ privacy limitation
tcamise-gpsw
force-pushed
the
bump_python_sdk_deps
branch
from
87dd9e5 to
3262a39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates third-party dependencies and adds compatibility for macOS 15+ privacy features that redact WiFi SSID names. The key changes include:
type: ignorecomments that are no longer needed with updated type checking