made some custom transport implementation possible#59
Open
sum-catnip wants to merge 2 commits intogoogleprojectzero:mainfrom
Open
made some custom transport implementation possible#59sum-catnip wants to merge 2 commits intogoogleprojectzero:mainfrom
sum-catnip wants to merge 2 commits intogoogleprojectzero:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
normally id publish the whole "linux implementation" but i only did the bare minimum as quickly as possible. Basically i just replaced the entire connect and bind part of this library with using SMBLibrary to connect and bind to a namedpipe. Then just used the pipes read and writefile functions for readfragment and writefragment. Thats i, but it works surprisingly well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
im using your library at work and i needed to make it linux compatible. I made some very minor changes that allowed me to make my own
RpcConnectedClientTransportimplementation. The changes made it possible to use the SMBLibrary as my transport method instead of the pinvoke/windows-dependant one. If you don't mind, it would be nice to have those changes in the main repo so:Have a nice day :)
Also thanks so much for creating this awesome project!