Pass environment variables to the engine in startup tests#535
Merged
Liedtke merged 2 commits intogoogleprojectzero:mainfrom Oct 20, 2025
Merged
Conversation
Liedtke
reviewed
Oct 20, 2025
| try inputPipe.fileHandleForWriting.close() | ||
|
|
||
| let environment = ProcessInfo.processInfo.environment.merging( | ||
| Dictionary(env, uniquingKeysWith: { _, new in new }), |
Collaborator
There was a problem hiding this comment.
This shouldn't have to be a Dictionary?
Suggested change
| Dictionary(env, uniquingKeysWith: { _, new in new }), | |
| env, |
Contributor
Author
There was a problem hiding this comment.
Good point. I overlooked https://developer.apple.com/documentation/swift/dictionary/merging(_:uniquingkeyswith:)-9bik6 and thought I had to construct a Dictionary explicitly.
CSharperMantle
force-pushed
the
feat-nullarg-validator-env
branch
from
639922f to
d2bf8bf
Compare
Liedtke
pushed a commit
that referenced
this pull request
Oct 20, 2025
* Make REPRL env property a list of tuples of (key, value) * Pass env vars when running startup tests
chase1k
pushed a commit
to VRIG-RITSEC/fuzzillai
that referenced
this pull request
Nov 13, 2025
…ectzero#535) * Make REPRL env property a list of tuples of (key, value) * Pass env vars when running startup tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR helps avoid potential mismatches in behavior between a startup test and subsequent fuzzing based on REPRL sessions.
After this patch, the startup tests on SpiderMonkey produce the following output:
Resolves #534.