Skip to content

Conversation

@chandra-siri
Copy link
Collaborator

chore: add system 3.9 tests as required

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Dec 17, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the repository's continuous integration settings to incorporate Python 3.9 system tests as a mandatory check for all new code. Concurrently, it removes legacy configurations related to Python 2, aligning the project with current Python versions and clarifying the CI pipeline's structure.

Highlights

  • Added Python 3.9 System Test Requirement: Integrated 'Kokoro system-3.9' as a required status check for branch protection, ensuring all new changes are validated against Python 3.9.
  • Removed Python 2 Branch Protection: Eliminated the 'python2' specific branch protection rules, streamlining the CI configuration by removing support for an outdated Python version.
  • Clarified Presubmit Configuration: Updated comments in the main presubmit configuration to explicitly state that system tests are disabled in this specific job because they are handled by separate, version-specific presubmit configurations (e.g., 'system-3.xx.cfg').
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds the 'Kokoro system-3.9' status check to the branch protection rules, which directly addresses the stated goal of incorporating system 3.9 tests. Additionally, the comment in the presubmit.cfg file has been updated for improved clarity regarding the disabling of system tests. However, a significant change involves the removal of the python2 branch protection rule. This modification is not explicitly mentioned in the pull request description and appears to be unrelated to the primary objective of adding system 3.9 tests. This could potentially leave active python2 branches unprotected, which warrants further consideration.

@chandra-siri chandra-siri marked this pull request as ready for review December 17, 2025 14:15
@chandra-siri chandra-siri requested review from a team as code owners December 17, 2025 14:15
@chandra-siri chandra-siri merged commit b8855b0 into main Dec 17, 2025
16 of 17 checks passed
@chandra-siri chandra-siri deleted the chore_add_sys_39 branch December 17, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants