-
Notifications
You must be signed in to change notification settings - Fork 168
chore: add system 3.9 tests as required #1670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the repository's continuous integration settings to incorporate Python 3.9 system tests as a mandatory check for all new code. Concurrently, it removes legacy configurations related to Python 2, aligning the project with current Python versions and clarifying the CI pipeline's structure. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully adds the 'Kokoro system-3.9' status check to the branch protection rules, which directly addresses the stated goal of incorporating system 3.9 tests. Additionally, the comment in the presubmit.cfg file has been updated for improved clarity regarding the disabling of system tests. However, a significant change involves the removal of the python2 branch protection rule. This modification is not explicitly mentioned in the pull request description and appears to be unrelated to the primary objective of adding system 3.9 tests. This could potentially leave active python2 branches unprotected, which warrants further consideration.
chore: add system 3.9 tests as required