Allow config_id as an alternative model_id to automodel#1002
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Allow config_id as an alternative model_id to automodel#1002copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
requested review from
abheesht17,
hgao327,
jiangyangmu,
lc5211,
sizhit2,
tianshub and
wang2yn84
as code owners
we don't want to force using the HF id as the only option for the model_id, especially for other sources, such as Kaggle/GCS/CNS. Alternatively, we allow the config_id from the model.py for each model family as the option to be used for model_id (and respectively model_name) for cli and Automodel. Tested by local launch of `./examples/rl/grpo/gsm8k/run_gemma2_2b.sh` on VM PiperOrigin-RevId: 861402268
copybara-service
bot
force-pushed
the
test_861402268
branch
from
96a68b3 to
c91cf25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow config_id as an alternative model_id to automodel
we don't want to force using the HF id as the only option for the model_id, especially for other sources, such as Kaggle/GCS/CNS. Alternatively, we allow the config_id from the model.py for each model family as the option to be used for model_id (and respectively model_name) for cli and Automodel.
Tested by local launch of
./examples/rl/grpo/gsm8k/run_gemma2_2b.shon VM