fix(a11y): enhance labels for destination photos button#232
Open
KenTandrian wants to merge 5 commits intogoogle:mainfrom
Open
fix(a11y): enhance labels for destination photos button#232KenTandrian wants to merge 5 commits intogoogle:mainfrom
KenTandrian wants to merge 5 commits intogoogle:mainfrom
Conversation
Collaborator
Author
|
Destination photos button: 
|
…ls-for-destination-photos-btn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an accessibility issue in the "Destination Photos" component where screen readers would incorrectly announce invisible photo links when the component was closed, and the main button lacked a descriptive label.
Changes
ModvilTrackerPhotoElementto support a disabled property that togglesaria-hiddenandtabindexon the internal link.ModvilTrackerStatsElement(the container) now iterates over its photo children to disable them when the view is closed, ensuring they are removed from the accessibility tree and keyboard tab order.aria-labelto the "Open" button (e.g., "City, Region, Local Guide images") so screen reader users understand the button's purpose and context.Impacted UI components
modvil-tracker-photosandmodvil-tracker-photo).