Remove more unused contact references#2961
Open
gbrodman wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
gbrodman
force-pushed
the
nonFunctionalContactRemovals
branch
from
5fb462e to
a7bd876
Compare
This avoids changing any functionality, including the bits of DomainCommand (representations of XML files) that reference contacts. Currently, we "allow" parsing of contacts in DomainCommands and fail later as part of the domain flow, even though in practice the parsing itself will fail now that no contacts exist in the database. Because we wish to keep the "contacts aren't allowed in flows" tests active (e.g. DomainUpdateFlowTest::testFailure_minimumDataset_whenAddingNewContacts) we have to keep the usages of contacts in DomainCommand active for now.
gbrodman
force-pushed
the
nonFunctionalContactRemovals
branch
from
a7bd876 to
0b6985f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids changing any functionality, including the bits of DomainCommand (representations of XML files) that reference contacts. Currently, we "allow" parsing of contacts in DomainCommands and fail later as part of the domain flow, even though in practice the parsing itself will fail now that no contacts exist in the database.
Because we wish to keep the "contacts aren't allowed in flows" tests active (e.g.
DomainUpdateFlowTest::testFailure_minimumDataset_whenAddingNewContacts) we have to keep the usages of contacts in DomainCommand active for now.
This change is