Skip to content

Use bash in the Nomulus image#2959

Merged
weiminyu merged 1 commit intogoogle:masterfrom
weiminyu:jetty-use-bash
Feb 18, 2026
Merged

Use bash in the Nomulus image#2959
weiminyu merged 1 commit intogoogle:masterfrom
weiminyu:jetty-use-bash

Conversation

@weiminyu
Copy link
Collaborator

@weiminyu weiminyu commented Feb 18, 2026

PR 2958 did not fix the jetty script because it uses bash syntax while the script specifies /bin/sh which links to dash on the jetty image.

/bin/bash comes with the jetty image. Use it in start.sh for safe scripting.

Tested in crash


This change is Reviewable

/bin/bash comes with the base image, jetty:jdk-??.
Use it in start.sh for safe scripting.
Copy link
Collaborator

@ptkach ptkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptkach reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on CydeWeys and gbrodman).

@weiminyu weiminyu added this pull request to the merge queue Feb 18, 2026
Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on CydeWeys).

Merged via the queue into google:master with commit e24c90f Feb 18, 2026
10 checks passed
@weiminyu weiminyu deleted the jetty-use-bash branch February 18, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments