RELATED: CQ-894 - rename flexfun package #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no23reason
reviewed
Nov 12, 2024
- FlexFunctions are now FlexConnect - We will discontinue the old gooddata-flexfun and instead use gooddata-flexconnect - Renamed everything accordingly - There should be no sight of FlexFun anywhere now JIRA: CQ-894 risk: low
JIRA: CQ-894 risk: low
no23reason
approved these changes
Nov 12, 2024
Contributor
no23reason
left a comment
no23reason
left a comment
There was a problem hiding this comment.
LGTM, good catch/memory with the missing py.typed file :)
Contributor
Author
got lucky .. found it in TODO in the template repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CQ-894
risk: low