support slice of custom types in expandSliceArgs#427
Open
Songmu wants to merge 3 commits intogo-gorp:mainfrom
Open
support slice of custom types in expandSliceArgs#427Songmu wants to merge 3 commits intogo-gorp:mainfrom
Songmu wants to merge 3 commits intogo-gorp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support slice of custom types like
[]UserID(type UserID int64).In this change, The
expandSliceArgsexpand if the slice element implementsdriver.Valueror is of a named primitive type.If the slice itself is of a certain type and implements
driver.Valuer,expandSliceArgsdoes not expand the slice. So it keeps backward compatibility.Typing as follows is reassuring in terms of type safety, and we define types in that way on our production.
In that case, this change is beneficial. What do you think?