Remove the legacy 'get_submission_id' mock #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An old mock for `get_submission_id` (as a YAML file) was still in use. However, `globus_sdk.testing` provides a mock for this API call which can be switched to trivially. Additionally, several tests were using the mock which no longer need it due to changes in SDK behavior to defer the request for a submission ID until it is actually needed.
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
kurtmckee
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An old mock for
get_submission_id(as a YAML file) was still in use.However,
globus_sdk.testingprovides a mock for this API call which canbe switched to trivially.
Additionally, several tests were using the mock which no longer need it
due to changes in SDK behavior to defer the request for a submission ID
until it is actually needed.