TrimSpace from string fingerprint before hex.DecodeString#106
Closed
jspraul wants to merge 2 commits intogithub:mainfrom
Closed
TrimSpace from string fingerprint before hex.DecodeString#106jspraul wants to merge 2 commits intogithub:mainfrom
jspraul wants to merge 2 commits intogithub:mainfrom
Conversation
Author
|
Sorry, requiring all commits to be signed wasn't mentioned in CONTRIBUTING.md, but it makes sense. If there's any interest in this at all (very minor issue and tiny fix) I can go through this again, signing commits this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rookie passing "-bsau [string fingerprint]" as one parameter when debugging. getopt still worked but didn't trim the leading space from string fingerprint.
The end of email parsing at
smimesign/parse_user_id.go
Line 106 in 3564e86
PS. Both my 👍 👍 's up for pull cgo windows to syscall #93 and @tg123, it's the only reason I'm here.