Add arm64 support to container image builds#16020
Closed
Conversation
Contributor
Smoke Test ResultsPRs Tested:
Test Results:
Overall Status: PASS ✅ cc
|
This was referenced Feb 16, 2026
- Update Dockerfile to use TARGETOS and TARGETARCH build args - Remove hardcoded BINARY build arg in favor of multi-platform automatic selection - Update release.md workflow to build for linux/amd64,linux/arm64 - Update Makefile docker-build to use buildx for consistency - Update docker_build_integration_test.go to check for new ARG format Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Add documentation for expected ARG values (TARGETOS, TARGETARCH) - Add note about explicit build args for local builds without buildx - Add binary validation step to fail fast if binary is missing or not executable Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update container image generation to support arm64
Add arm64 support to container image builds
Feb 16, 2026
Contributor
|
@copilot review changes and make sure they are correct and validated. Update Dockerfile tests. |
- Add dist directory preparation in docker-build and docker-build-multiarch targets
- Copy binaries from repo root to dist/linux-amd64 and dist/linux-arm64
- Update TestDockerBuild_WithMake to verify dist directory structure is created
- Add verification for both amd64 and arm64 binaries in tests
- Add dist/${TARGETOS}-${TARGETARCH} pattern check in Dockerfile tests
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Changes reviewed and validated. Updated Dockerfile tests and fixed Makefile to properly create dist directory structure for multi-platform builds. Key fixes in commit 1fc6df0:
All integration tests pass ✓ |
Contributor
|
@copilot do another round of review. Check ci.yml. |
- Replace old docker build with docker buildx build for consistency - Add dist directory preparation step before Docker build - Remove obsolete --build-arg BINARY parameter - Use --platform linux/amd64 and --load flags for CI testing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Reviewed ci.yml and updated the Alpine container test job to use the new Docker build approach. Changes in commit 8694065:
The CI workflow now uses the same build process as the release workflow and Makefile ✓ |
Contributor
|
@copilot make sure ci.yml has a job that tests the arm64 build as well |
- Add new alpine-container-test-arm64 job to test ARM64 Docker builds - Set up QEMU emulation for ARM64 architecture testing - Build and test ARM64 Docker image with --platform linux/arm64 - Run compile command and verify lock file generation on ARM64 - Test verifies ARM64 binary works correctly in Alpine container - Provides comprehensive ARM64 build validation in CI Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Added ARM64 container test job to CI workflow in commit 4472fc1. New
CI now tests both AMD64 ( |
Contributor
|
@copilot do a complete review of the changes for consistency. Ensure running release.md will produce images for arm64/amd64 |
Contributor
|
PRs: Remove SupportsHTTPTransport from engine interface; Enforce add_comment constraints at MCP server invocation
|
Contributor
- Add QEMU setup to release.md for ARM64 cross-compilation support - Add default values to Dockerfile ARGs (TARGETOS=linux, TARGETARCH=amd64) - Add buildx availability check to Makefile docker-build target - Ensures multi-platform builds work reliably on amd64 runners - Improves local development experience with better defaults and error messages Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Fixed CI failure and addressed PR review feedback in commit e2aa789. Root cause: Multi-platform Docker builds (linux/amd64,linux/arm64) require QEMU emulation on AMD64 runners to execute ARM64 binaries during the build process. Fixes applied:
The release workflow will now successfully build and push multi-platform images ✓ Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
Contributor
|
🧪 Smoke Project is now testing project operations... |
Contributor
|
🧪 Smoke Temporary ID is now testing temporary ID functionality... |
Contributor
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Contributor
|
💫 TO BE CONTINUED... Smoke Claude failed! Our hero faces unexpected challenges... |
Contributor
|
❌ Smoke Copilot SDK failed. Please review the logs for details. |
Contributor
|
📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident... |
This was referenced Feb 16, 2026
Contributor
Agent Container Tool Check
Result: 12/12 tools available ✅
|
Contributor
|
✅ Smoke Temporary ID completed successfully. Temporary ID validation passed. |
Contributor
|
✅ Smoke Project completed successfully. All project operations validated. |
Contributor
|
PRs: Fix enable/disable ignoring --repo flag for workflow status check | Fix nil pointer panic in DirExists on permission errors
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container images were only built for linux/amd64 despite release binaries being compiled for both amd64 and arm64 architectures.
Changes
BINARYbuild arg with Buildx automaticTARGETOS/TARGETARCHargs for platform-aware binary selection, with defaults (TARGETOS=linux,TARGETARCH=amd64) for local developmentlinux/amd64,linux/arm64docker-buildtarget fromdocker buildtodocker buildx buildwith buildx availability check, and add dist directory preparation to copy binaries from repo root (gh-aw-linux-amd64,gh-aw-linux-arm64) to expected structure (dist/linux-amd64,dist/linux-arm64)alpine-container-testjob to use new Docker build approach with dist directory preparation and Buildx setup. Add newalpine-container-test-arm64job with QEMU emulation to test ARM64 Docker builds--versioncheck post-copy to fail fast on missing/incorrect binariesSingle
docker buildx buildcommand now produces native images for both platforms. QEMU emulation enables ARM64 builds on AMD64 runners without "exec format error" failures.CI Testing
The CI workflow now includes comprehensive multi-platform testing:
Both jobs verify that Docker images can be built, binaries work correctly, and the compile command functions properly in containers for their respective architectures.
Developer Experience Improvements
docker buildfor local developmentOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Changeset
Changeset
Changeset