Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the throttler's behavior to return HTTP 200 status code when no hosts are found, rather than treating it as an error condition.
- Export the
NoHostsErrorvariable to make it publicly accessible for error checking - Add specific handling for
NoHostsErrorin the throttler check logic to return HTTP 200 - Add comprehensive test coverage for the throttler check functionality including the new no-hosts behavior
Reviewed Changes
Copilot reviewed 6 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/base/throttle_metric.go | Export NoHostsError by capitalizing the variable name |
| pkg/throttle/check.go | Add error handling to return HTTP 200 when no hosts are found |
| pkg/throttle/throttler_test.go | Add comprehensive test suite for throttler check behavior |
| pkg/throttle/check_result.go | Reorder imports for consistency |
| pkg/mysql/mysql_inventory.go | Add blank line for import formatting |
| go.mod | Add testify dependency for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
andyedison
approved these changes
Aug 20, 2025
andyedison
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if freno finds no backend hosts to collect metrics from it returns 500. We find it preferable to fail open in this case and return 200. For example if hosts are unavailable from one "domain" we can still operate with the metrics from the other domains.