Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds an environment-driven bypass mode to the HTTP API, allowing throttle checks to be skipped when FRENO_BYPASS_ENABLED is set.
- Introduces
bypassEnabledfield onAPIImpland reads it fromFRENO_BYPASS_ENABLED. - Short-circuits
checkhandler to always return HTTP 200 when bypass is enabled.
Comments suppressed due to low confidence (2)
pkg/http/api.go:65
- Add a comment above this field explaining that when true, throttle checks are bypassed to clarify its purpose in the API behavior.
bypassEnabled bool
pkg/http/api.go:171
- Add unit tests for the bypass path to verify that throttle checks are correctly short-circuited and return HTTP 200 when bypass is enabled.
if api.bypassEnabled {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 8dd637c.
SrRyan
reviewed
Jun 19, 2025
pkg/throttle/throttler.go
Outdated
| } | ||
| if len(totalHosts) == 0 { | ||
| if throttler.BypassOnNoHostsFound { | ||
| log.Debugf("No hosts for pool: %+v, but bypass is enabled", poolName) |
There was a problem hiding this comment.
metrics.GetOrRegisterCounter("<name>", nil).Inc(1)
mhamza15
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.