Skip to content

C++: Rename holdsInBase to isBase #21200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
igfoo wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Draft

C++: Rename holdsInBase to isBase #21200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/ql/lib/semmle/code/cpp/internal/Overlay.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ private string getMultiLocationFilePath(@element e) {
* overlay variant.
*/
overlay[local]
private predicate holdsInBase() { not isOverlay() }
private predicate isBase() { not isOverlay() }

/**
* Discards an element from the base variant if:
Expand All @@ -71,7 +71,7 @@ private predicate holdsInBase() { not isOverlay() }
*/
overlay[discard_entity]
private predicate discardElement(@element e) {
holdsInBase() and
isBase() and
(
overlayChangedFiles(getSingleLocationFilePath(e))
or
Expand Down
Loading