C#: Fix some Ql4Ql violations.#20326
Merged
michaelnebel merged 2 commits intogithub:mainfrom Sep 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes various Ql4Ql violations identified by automated checks, focusing on code quality improvements in the C# CodeQL library. The changes include refactoring to use more idiomatic CodeQL patterns, fixing spelling errors, and improving code documentation.
Key changes:
- Replace
existspatterns with more conciseinstanceofchecks - Fix spelling errors in class names and predicates
- Move field declarations inside
existsclauses to improve scoping - Add missing parameter documentation
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
DatabaseQuality.qll |
Replace exists with instanceof for cleaner type checking |
UselessUpcast.ql |
Move field declaration inside exists clause for better scoping |
MagicConstants.qll |
Fix spelling error from "occurence" to "occurrence" |
Deserializers.qll |
Fix spelling error in class name and add deprecated alias |
UnsafeDeserializationQuery.qll |
Update reference to corrected class name |
SsaImpl.qll |
Add missing parameter documentation |
SSA.qll |
Remove unused field by using wildcard in exists clause |
Completion.qll |
Replace field with inline any() expression |
PrintAst.qll |
Refactor to use any() pattern instead of field |
Member.qll |
Add missing parameter documentation |
Callable.qll |
Fix spelling error "substraction" to "subtraction" |
Assignable.qll |
Add missing parameter documentation |
printAst.ql |
Fix documentation grammar |
Comments suppressed due to low confidence (1)
csharp/ql/lib/printAst.ql:22
- Grammar error: 'the element is
eisfromSource' should be 'the elementeisfromSource' (remove duplicate 'is').
* Holds if the location `l` matches the selected file in the VS Code extension and
* the element is `e` is `fromSource`.
hvitved
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some Ql4Ql violations based on the following checks
ql/field-only-used-in-charpredql/could-be-castql/counting-to-zeroql/dataflow-module-naming-conventionql/if-with-noneql/missing-parameter-qldocql/misspellingDCA looks good.