Rust: Adjust jump-to-def for paths with generic arguments#20248
Merged
hvitved merged 2 commits intogithub:mainfrom Aug 21, 2025
Merged
Rust: Adjust jump-to-def for paths with generic arguments#20248hvitved merged 2 commits intogithub:mainfrom
hvitved merged 2 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines jump-to-definition behavior for Rust paths containing generic arguments by adjusting the target location from the entire path segment to just the identifier portion. The change ensures that when users invoke jump-to-definition on paths like M1::S2::<S>::new(S), they navigate to the precise identifier S2 rather than the entire segment including generic arguments.
- Changes the target element for path-based jump-to-definition from
PathSegmenttoNameRef - Updates the constructor logic to use the segment's identifier instead of the segment itself
- Adds test cases with generic struct definitions and usage to validate the improved behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/test/library-tests/definitions/main.rs | Adds test struct S2<T> with generic parameter and usage example with generic arguments |
| rust/ql/test/library-tests/definitions/Definitions.expected | Updates expected test results with new definition mappings including generic type references |
| rust/ql/lib/codeql/rust/internal/Definitions.qll | Modifies PathUse class to target NameRef instead of PathSegment for more precise jump-to-definition |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After