Type inference: Rename some variables#20234
Merged
hvitved merged 1 commit intogithub:mainfrom Aug 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames variables in TypeInference.qll to improve consistency with naming conventions used in the conditionSatisfiesConstraint function. The changes ensure that variable names clearly distinguish between conditions and constraints throughout the type inference logic.
- Renames variables to use
condition/constraintnaming pattern consistently - Updates parameter order in
potentialInstantiationOfto align with consistent naming - Improves code readability by using more descriptive variable names
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename variables to be consistent with the naming used in
conditionSatisfiesConstraint.