Skip to content

Conversation

@ericbsd
Copy link
Member

@ericbsd ericbsd commented Oct 31, 2025

  • Split freebsd-update into a separate package
  • Include in minimal-jail annotation set
  • Make jail package depend on freebsd-update

GhostBSD does not use freebsd-update it will be removed from the default.

Summary by Sourcery

Introduce a standalone freebsd-update package and update the jail-all package to depend on it.

New Features:

  • Split freebsd-update into its own package with accompanying UCL descriptor
  • Include freebsd-update in the minimal-jail annotation set and require it in the jail-all package

Build:

  • Add Makefile support for the freebsd-update package

- Split freebsd-update into separate package
- Include in minimal-jail annotation set
- Make jail package depend on freebsd-update
@ericbsd ericbsd requested review from a team as code owners October 31, 2025 21:14
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 31, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refactors the freebsd-update tool into its own package by updating its Makefile, introduces a new UCL annotation for minimal jail sets, and ensures the jail package declares a dependency on freebsd-update.

Entity relationship diagram for UCL annotation sets

erDiagram
  JAIL_ALL {
    string name
    string[] annotations
  }
  FREEBSD_UPDATE_ALL {
    string name
    string[] annotations
  }
  JAIL_ALL ||--o{ FREEBSD_UPDATE_ALL : includes
Loading

Class diagram for package structure changes

classDiagram
  class JailPackage {
    +depends_on: freebsd-update
  }
  class FreebsdUpdatePackage {
    +Makefile
    +freebsd-update.conf
    +freebsd-update.sh
    +freebsd-update.8
  }
  JailPackage --> FreebsdUpdatePackage
Loading

File-Level Changes

Change Details Files
Refactor freebsd-update into a standalone package
  • Define PACKAGE variable for freebsd-update
  • Separate configuration, scripts, and man pages under the new package
  • Adjust Makefile layout accordingly
usr.sbin/freebsd-update/Makefile
Integrate freebsd-update into jail annotation and dependencies
  • Create freebsd-update-all.ucl for minimal-jail annotation
  • Update jail-all.ucl to include freebsd-update annotation
  • Add dependency declaration on freebsd-update in jail package
release/packages/ucl/freebsd-update-all.ucl
release/packages/ucl/jail-all.ucl

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

Thank you for taking the time to contribute to FreeBSD!
There is an issue that needs to be fixed:

  • Missing Signed-off-by lines8140b66

Please review CONTRIBUTING.md, then update and push your branch again.

@ericbsd
Copy link
Member Author

ericbsd commented Oct 31, 2025

test this

@ericbsd ericbsd merged commit 49faaf8 into releng/15.0 Nov 2, 2025
8 of 9 checks passed
@ericbsd ericbsd deleted the freebsd-update-pkg branch November 2, 2025 22:34
@github-project-automation github-project-automation bot moved this from In Review to Done in Development Tracker Nov 2, 2025
@ericbsd ericbsd changed the title Create a freebsd-update package and adding t to jail dependency Create a freebsd-update package and adding it to jail dependency Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants