Move color scheme fixes to User directory#77
Open
tdhsmith wants to merge 2 commits intoggordan:masterfrom
tdhsmith:master
Open
Move color scheme fixes to User directory#77tdhsmith wants to merge 2 commits intoggordan:masterfrom tdhsmith:master
tdhsmith wants to merge 2 commits intoggordan:masterfrom
tdhsmith:master
Conversation
Package Control users utilizing the 'fix color scheme' feature would have their schemes overwritten on every update, leading to an annoying 'missing color scheme' popup. This moves future fixes to the User folder to avoid deletion. Since the issue affects this update as well, there is also a small function to fail a bit more gracefully, reverting missing themes to Monokai rather than generating endless dialog boxes (which is Sublime's ridiculous default behavior).
Collaborator
Author
|
(I'm going to test this on other OSes first.) |
Collaborator
|
Let me know once tested. Looks fine though. |
Collaborator
Author
|
Seems good. Yeah it wasn't a big change but I want to test whenever I introduce a file system manipulation. 😉 |
Collaborator
Author
|
I don't know if you prefer each change to have its own version, but FYI I'll be working on the HSL parsing issue in an hour or so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package Control users utilizing the 'fix color scheme' feature would
have their schemes overwritten on every update, leading to an annoying
'missing color scheme' popup. This moves future fixes to the User folder
to avoid deletion.
Since the issue affects this update as well, there is also a small
function to fail a bit more gracefully, reverting missing themes to
Monokai rather than generating endless dialog boxes (which is Sublime's
ridiculous default behavior).
Fixes #68