fix(logs): write nil-event_id-envelopes to random UUID filename
#1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this avoids collisions with the nil-event_id-envelope for sessions on Crashpad
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
JoshuaMoelans
requested review from
mujacica
and removed request for
mujacica
JoshuaMoelans
changed the title
event_id to logs envelopeevent_id-envelopes to random UUID filename
Member
Author
|
@sentry review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to avoid collisions with the nil-event_id-envelope for sessions on Crashpad, where on crash we would try to write both the logs envelope and session envelope to the same file.
Since the original nil-id filename (
00000000-0000-0000-0000-000000000000.envelope) had no meaning (and wasn't handled differently in reprocessing old runs) writing a random UUID should be fine.#skip-changelog