Open
Conversation
Contributor
|
@ken-bem I can see your intent. I like the idea to support CORS in general. I see one big problem with your implementation: You get to turn it off (no CORS) or on (EveryDomainThatExists CORS). If we allow to turn on CORS we should make it a little bit more configurable. Could you implement the possibility to set allowed Domains? |
Author
|
Well i can make the changes quickly and i you can check back and give your feedback it would be great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Support in the framework for CORS request, only need to add 'CORS' key to the herbert.config.php file