Load plugin during init face to prevent race conditions#25
Closed
dryajov wants to merge 2 commits intogetherbert:devfrom
Closed
Load plugin during init face to prevent race conditions#25dryajov wants to merge 2 commits intogetherbert:devfrom
dryajov wants to merge 2 commits intogetherbert:devfrom
Conversation
dryajov
changed the title
Contributor
Author
|
@jeremyzahner I've opened two separate prs #27 and #28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting an NPE due to a null
$wp_rewriteregistering a page type. I think it makes sense to delay plugin bootstrap/registration to the init face when WP is initialized.Unless I'm missing something, there also seems to be a bug in the way the shortcode callback is being invoked, since all the parameters are being merged into an array. Commit c5ae587 addresses that.