Add Cache class for using WordPress built-in transients in more readable way#14
Open
onnimonni wants to merge 3 commits intogetherbert:devfrom
Open
Add Cache class for using WordPress built-in transients in more readable way#14onnimonni wants to merge 3 commits intogetherbert:devfrom
onnimonni wants to merge 3 commits intogetherbert:devfrom
Conversation
added 3 commits
August 31, 2015 23:59
Contributor
|
@onnimonni I guess you could manage merging this yourself? =) |
Contributor
Author
|
I just didn't hear thoughts from anyone else. Does this look like something others would be interested as well? |
Contributor
Author
|
@jasonagnew I know you're busy, but do you have opinions 😃? |
Contributor
|
@onnimonni I think it's great. What we (you) probably should do, is integrate such changes in a finished project done with Herbert to see if it is working as intended. |
Contributor
Author
|
That's harder for me to do because the project where I used these is closed source and owned by my client. I can hopefully do unit tests instead. |
Contributor
|
@onnimonni Yeah, merging all kind of new functionality much quicker will become easier once we get proper unit tests for the framework. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I just love to use transients for almost everything in WordPress. It enhances loading speeds significantly. But I'm always frustrated how ugly it looks:
I used anonymous functions to create
Cacheclass so you could refactor upper code example into:This should be familiar for all javascript guys using herbert.
This also respects
Pragma: no-cacheheaders from the request.There might be better and more readable ways than this but I'm adding it here as a suggestion.