Add matchers to enable lte-defined Elm versions#54
Open
knuton wants to merge 1 commit intogdotdesign:masterfrom
Open
Add matchers to enable lte-defined Elm versions#54knuton wants to merge 1 commit intogdotdesign:masterfrom
knuton wants to merge 1 commit intogdotdesign:masterfrom
Conversation
d044926 to
bd5dc71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a problem when adding a dependency to
tesk9/accessible-html,v3.1.0:The code to determine the Elm version of a package assumes that the version constraint is always of the shape
a.b.c <= v < x.y.z, butaccessible-htmlspecifies the Elm version in different way: https://github.com/tesk9/accessible-html/blob/3.1.0/elm-package.json#L23This is a hot fix that extends the existing hack.
Ideas for a proper solution
The nice solution would be to resolve the Elm version constraints of the packages for compatibility. As far as I can see the Solve library does not offer that option.
How about adding the required Elm versions to the constraint set and adding an auto-detected (but configurable) Elm version to the graph?