Skip to content

Add support for specifying a UPM_REGISTRY_USER#299

Open
ahaaf-transfr wants to merge 7 commits intogame-ci:mainfrom
TRANSFR-Inc:upm-user
Open

Add support for specifying a UPM_REGISTRY_USER#299
ahaaf-transfr wants to merge 7 commits intogame-ci:mainfrom
TRANSFR-Inc:upm-user

Conversation

@ahaaf-transfr
Copy link

@ahaaf-transfr ahaaf-transfr commented Oct 28, 2025

Changes

  • Added the ability to specify a UPM_REGISTRY_USER for the .upmconfig.toml since some NPM registries require it to exist/be present when using to authenticate.

Related PRs

Successful Workflow Run Link

I'm unsure if the tests are necessary but I can fix that if needed.

I ran into problems running the tests on my OSX machine unfortunately so I am unsure if the project generated correctly.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Summary by CodeRabbit

  • Chores
    • Added a new environment variable for private registry user authentication to support authenticated registry access.
    • Enabled manual triggering of the CI workflow so runs can be started on demand in addition to automatic triggers.

@github-actions
Copy link

Cat Gif

@coderabbitai
Copy link

coderabbitai bot commented Oct 28, 2025

📝 Walkthrough

Walkthrough

Added PRIVATE_REGISTRY_USER (sourced from process.env.UPM_REGISTRY_USER) to the image environment factory; enabled manual workflow trigger (workflow_dispatch) in the GitHub Actions workflow. No exported/public signatures changed.

Changes

Cohort / File(s) Summary
Environment variable addition
src/model/image-environment-factory.ts
Added PRIVATE_REGISTRY_USER to the emitted EnvironmentVariables, sourcing from process.env.UPM_REGISTRY_USER. No logic or signature changes.
Workflow trigger
.github/workflows/main.yml
Added workflow_dispatch to the workflow triggers to allow manual runs. No other workflow steps or behavior changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped into the code today,
A private name tucked in the tray,
A button wakes the workflow's hum,
Small changes made — the circuits run,
I twitch my nose and bound away.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly summarizes the main change: adding support for specifying a UPM_REGISTRY_USER environment variable, which matches the primary modification in image-environment-factory.ts.
Description check ✅ Passed The description covers the key required sections: changes are documented, related documentation PR is referenced, a successful workflow run is provided, and the checklist is completed. However, the Docs checklist item is left unchecked despite mentioning a related documentation PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ahaaf-transfr ahaaf-transfr changed the title Upm user Add support for specifying a UPM_REGISTRY_USER Oct 28, 2025
Copy link
Member

@davidmfinol davidmfinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need a successful run with all the tests passing

@ahaaf-transfr
Copy link
Author

@davidmfinol I've managed to run all the tests except for 1 here: Test each mode sequentially 👩‍👩‍👧‍👦 (windows-2022, 2022.3.13f1, unity-project-w, which doesn't seem related to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants