Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimises the clone list creation by using maps and sets. Instead of maintaining a list of lists, we maintain a hashmap mapping SCCSnippetIDs to sets of SCCSnippetIDs. This allows O(1) lookup of ids instead of scanning all lists. All SCCSnippetIDs that are considered clones map to the same set of IDs. This is achieved by merging sets of ids when linked by a clone pair.
Preliminary results suggest a factor 100 speed-up for this particular method. I don't know how it will affect the overall run-time of the program.