Added the missing Mac disconnect functionality#99
Open
xavier7179 wants to merge 5 commits intofriedrith:masterfrom
Open
Added the missing Mac disconnect functionality#99xavier7179 wants to merge 5 commits intofriedrith:masterfrom
xavier7179 wants to merge 5 commits intofriedrith:masterfrom
Conversation
- Added a mac-disconnect function (based on wifi-control), which makes possible to disconnect from the actual network without running 'root' commands - Configs expanded to handle the possibility of waiting a fixed time between the two OSX required command
|
These edits do not lead to the desired result, since after turning off and on the wifi module there will be an automatic connection to the priority access point MacOs Catalina 10.15.5 |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added a disconnect function by using CLI functions that do not require to be root. Those functions turn off the wifi first and, after an optional delay, turn it on again. Since disconnecting from a network or a device properly may require a delay, I included a sleep function to do it without generating a Promise, like a setTimeout would do.
Motivation and Context
On Mac the disconnect was a missed functionality.
Usage examples
const WiFiControl = require('node-wifi');
WiFiControl.init({
iface: null,
debug: true,
delay: 5 // delay in seconds
});
//....
WiFiControll.disconnect();
How Has This Been Tested?
I tested it on OSX version 10.14.6.
Types of changes