fix(ban): allow ban verification when banned member already removed #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ban verification would fail with `MemberNotFound` if the banned member was no longer in the member list. This created an impossible state: banning a member removes them from the list, but verifying the ban required them to still be present. The fix recognizes that if a banned member is not in the member list, the ban has already taken effect (member was removed) and is therefore valid. The invite chain verification is skipped in this case since: 1. The ban signature verification still proves authenticity 2. The invite chain was valid when the ban was first created/applied This fixes a bug where message propagation would fail after kicking a user, because the merged state (with ban but without banned member) couldn't pass validation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When a user was kicked (banned), the state would become:
bans: contains the ban entrymembers: banned member already removedThe ban verification would fail with
MemberNotFoundbecause it required the banned member to still be in the member list. This created an impossible state where:Solution
If the banned member is not in the member list, the ban has already taken effect and is valid. Skip the invite chain verification in this case since:
Test plan
🤖 Generated with Claude Code