feat: adds fuzzy search and adds serbian translation#209
Open
ikslavok wants to merge 2 commits intofrappe:masterfrom
Open
feat: adds fuzzy search and adds serbian translation#209ikslavok wants to merge 2 commits intofrappe:masterfrom
ikslavok wants to merge 2 commits intofrappe:masterfrom
Conversation
ikslavok
changed the title
ikslavok
changed the title
Member
|
@sokumon can you check? |
iamejaaz
changed the title
iamejaaz
reviewed
Jun 29, 2025
| }; | ||
| } | ||
|
|
||
| const filterMatchStrategy = data && data.options && data.options.filterMatchStrategy; |
Member
There was a problem hiding this comment.
Suggested change
| const filterMatchStrategy = data && data.options && data.options.filterMatchStrategy; | |
| const filterMatchStrategy = data?.options?.filterMatchStrategy'; |
iamejaaz
reviewed
Jun 29, 2025
| } | ||
|
|
||
| function guessFilter(keyword = '') { | ||
| function guessFilter(keyword = '', data) { |
Member
There was a problem hiding this comment.
If only the strategy is used here, then in my opinion, there's no need to pass the whole data object — you can just pass the strategy directly and set its default value to 'strict'
iamejaaz
reviewed
Jun 29, 2025
Comment on lines
+231
to
+242
| if (filterMatchStrategy === 'fuzzy' && keyword.includes(' ')) { | ||
| return { | ||
| type: 'fuzzy', | ||
| text: compareString.toLowerCase() | ||
| }; | ||
| } | ||
| if (filterMatchStrategy === 'tokens' && keyword.includes(' ')) { | ||
| return { | ||
| type: 'tokens', | ||
| text: compareString.toLowerCase() | ||
| }; | ||
| } |
Member
There was a problem hiding this comment.
The only difference between this and the return statement below is the type value. You could simplify the logic by assigning the type to a variable and defaulting it to 'contains'.
|
@ikslavok Thanks for your work. Will you implement the review comments? Would love for this to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gives ability to provide aditional option that defines how columns will be filtered when using search functionality.
filterMatchStrategy: 'strict', // strict, fuzzy, tokens